add CI coverage for Tokenserver Python tests#2171
Closed
MooseTheRebel wants to merge 4 commits intomozilla-services:masterfrom
Closed
add CI coverage for Tokenserver Python tests#2171MooseTheRebel wants to merge 4 commits intomozilla-services:masterfrom
MooseTheRebel wants to merge 4 commits intomozilla-services:masterfrom
Conversation
MooseTheRebel
force-pushed
the
enhancement/testing-coverage-and-pytest
branch
from
42b1185 to
e6767fb
Compare
MooseTheRebel
force-pushed
the
enhancement/testing-coverage-and-pytest
branch
from
e6767fb to
7f06cde
Compare
Author
|
Sorry for the noise on this PR, I had to catch up to This is just my little attempt to help with the project, and to help with #1210 |
Member
|
@MooseTheRebel thank you for the contribution and pointing this out! We ended up resolving this in #2195 -- I'll note we might change this in the future to have it work a lot more like your branch does (but I think we're blocked from doing so currently per #2264) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
tokenserver-unit-testsCI job to run the Tokenserver Python unit tests on every push. Previously these tests had no GitHub Actions coverage, meaning failures could go undetected. This is a small step toward the broader goal in #1210.Testing
CI should be used to validate these changes.
Issue(s)
Relates to #1210.